aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2022-10-06 13:03:32 -0700
committerGitHub <noreply@github.com>2022-10-06 13:03:32 -0700
commit33cf0a604c111fc291dffaa0fb104336cb7d0add (patch)
treebcf8f995c5761d8c0a677f0b0a358bc1eb28bb5b /Objects
parentgh-86482: Document assignment expression need for ()s (GH-23291) (diff)
downloadcpython-33cf0a604c111fc291dffaa0fb104336cb7d0add.tar.gz
cpython-33cf0a604c111fc291dffaa0fb104336cb7d0add.tar.bz2
cpython-33cf0a604c111fc291dffaa0fb104336cb7d0add.zip
gh-97943: PyFunction_GetAnnotations should return a borrowed reference. (GH-97949)
(cherry picked from commit 6bfb0be80486c614cd60dce44c9fe7b3e6c76e3b) Co-authored-by: larryhastings <larry@hastings.org>
Diffstat (limited to 'Objects')
-rw-r--r--Objects/funcobject.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/Objects/funcobject.c b/Objects/funcobject.c
index 32b4155c03e..63074634747 100644
--- a/Objects/funcobject.c
+++ b/Objects/funcobject.c
@@ -300,7 +300,6 @@ func_get_annotation_dict(PyFunctionObject *op)
}
Py_SETREF(op->func_annotations, ann_dict);
}
- Py_INCREF(op->func_annotations);
assert(PyDict_Check(op->func_annotations));
return op->func_annotations;
}
@@ -532,7 +531,11 @@ func_get_annotations(PyFunctionObject *op, void *Py_UNUSED(ignored))
if (op->func_annotations == NULL)
return NULL;
}
- return func_get_annotation_dict(op);
+ PyObject *d = func_get_annotation_dict(op);
+ if (d) {
+ Py_INCREF(d);
+ }
+ return d;
}
static int