summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorchenglin.bi <chenglin.bi@linaro.org>2022-11-09 05:07:44 +0800
committerTom Stellard <tstellar@redhat.com>2022-11-10 17:00:50 -0800
commit6750e341b076d10a336c662ed6916500fdb20105 (patch)
tree8d853b005cded71dbca6d88f8db88acb01758f73
parent[cmake] Add missing CMakePushCheckState include to FindLibEdit.cmake (diff)
downloadllvm-project-6750e341b076d10a336c662ed6916500fdb20105.tar.gz
llvm-project-6750e341b076d10a336c662ed6916500fdb20105.tar.bz2
llvm-project-6750e341b076d10a336c662ed6916500fdb20105.zip
[TypePromotion] Replace Zext to Truncate for the case src bitwidth is larger
Fix: https://github.com/llvm/llvm-project/issues/58843 Reviewed By: samtebbs Differential Revision: https://reviews.llvm.org/D137613 (cherry picked from commit 597f44409236bf7fa933a4ce18af23772e28fb43)
-rw-r--r--llvm/lib/CodeGen/TypePromotion.cpp8
-rw-r--r--llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll20
2 files changed, 27 insertions, 1 deletions
diff --git a/llvm/lib/CodeGen/TypePromotion.cpp b/llvm/lib/CodeGen/TypePromotion.cpp
index 8dc8d381ad16..a63118067139 100644
--- a/llvm/lib/CodeGen/TypePromotion.cpp
+++ b/llvm/lib/CodeGen/TypePromotion.cpp
@@ -569,7 +569,8 @@ void IRPromoter::TruncateSinks() {
void IRPromoter::Cleanup() {
LLVM_DEBUG(dbgs() << "IR Promotion: Cleanup..\n");
// Some zexts will now have become redundant, along with their trunc
- // operands, so remove them
+ // operands, so remove them.
+ // Some zexts need to be replaced with truncate if src bitwidth is larger.
for (auto *V : Visited) {
if (!isa<ZExtInst>(V))
continue;
@@ -584,6 +585,11 @@ void IRPromoter::Cleanup() {
<< "\n");
ReplaceAllUsersOfWith(ZExt, Src);
continue;
+ } else if (ZExt->getSrcTy()->getScalarSizeInBits() > PromotedWidth) {
+ IRBuilder<> Builder{ZExt};
+ Value *Trunc = Builder.CreateTrunc(Src, ZExt->getDestTy());
+ ReplaceAllUsersOfWith(ZExt, Trunc);
+ continue;
}
// We've inserted a trunc for a zext sink, but we already know that the
diff --git a/llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll b/llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll
new file mode 100644
index 000000000000..983a32029c65
--- /dev/null
+++ b/llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll
@@ -0,0 +1,20 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -mtriple=aarch64 -type-promotion -verify -S %s -o - | FileCheck %s
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
+
+; Check the case don't crash due to zext source type bitwidth
+; larger than dest type bitwidth.
+define i1 @test(i8 %arg) {
+; CHECK-LABEL: @test(
+; CHECK-NEXT: [[EXT1:%.*]] = zext i8 [[ARG:%.*]] to i64
+; CHECK-NEXT: [[TMP1:%.*]] = and i64 [[EXT1]], 7
+; CHECK-NEXT: [[TMP2:%.*]] = trunc i64 [[TMP1]] to i32
+; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[TMP2]], 0
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %ext1 = zext i8 %arg to i64
+ %trunc = trunc i64 %ext1 to i3
+ %ext2 = zext i3 %trunc to i8
+ %cmp = icmp ne i8 %ext2, 0
+ ret i1 %cmp
+}