diff options
author | 2021-04-20 16:17:05 +0530 | |
---|---|---|
committer | 2021-04-20 16:17:15 +0530 | |
commit | 840c4e4e90c9022ee4b5775dde73f21450ec3ce4 (patch) | |
tree | 24a9e10efb8911e4d1721d8d2366adc3fc79d6f2 | |
parent | [MemoryBuiltins] Added support for memalign (diff) | |
download | llvm-project-840c4e4e90c9022ee4b5775dde73f21450ec3ce4.tar.gz llvm-project-840c4e4e90c9022ee4b5775dde73f21450ec3ce4.tar.bz2 llvm-project-840c4e4e90c9022ee4b5775dde73f21450ec3ce4.zip |
[AMDGPU] Re-arrange ds_read/ds_write ISel pattern for better readability.
Reviewed By: foad
Differential Revision: https://reviews.llvm.org/D100773
-rw-r--r-- | llvm/lib/Target/AMDGPU/DSInstructions.td | 20 |
1 files changed, 4 insertions, 16 deletions
diff --git a/llvm/lib/Target/AMDGPU/DSInstructions.td b/llvm/lib/Target/AMDGPU/DSInstructions.td index ddd37db5080a..9b15a1a2d5ee 100644 --- a/llvm/lib/Target/AMDGPU/DSInstructions.td +++ b/llvm/lib/Target/AMDGPU/DSInstructions.td @@ -842,9 +842,6 @@ let AddedComplexity = 100 in { foreach vt = VReg_64.RegTypes in { defm : DSReadPat_mc <DS_READ_B64, vt, "load_align8_local">; -} - -foreach vt = VReg_64.RegTypes in { defm : DSWritePat_mc <DS_WRITE_B64, vt, "store_align8_local">; } @@ -852,34 +849,25 @@ let SubtargetPredicate = isGFX7Plus in { foreach vt = VReg_96.RegTypes in { defm : DSReadPat_mc <DS_READ_B96, vt, "load_align16_local">; -} - -foreach vt = VReg_96.RegTypes in { defm : DSWritePat_mc <DS_WRITE_B96, vt, "store_align16_local">; } foreach vt = VReg_128.RegTypes in { defm : DSReadPat_mc <DS_READ_B128, vt, "load_align16_local">; -} - -foreach vt = VReg_128.RegTypes in { defm : DSWritePat_mc <DS_WRITE_B128, vt, "store_align16_local">; } let SubtargetPredicate = HasUnalignedAccessMode in { -// FIXME: Is ds_read_b96/ds_write_b96 better choice in unaligned-access-mode? +// FIXME: From performance point of view, is ds_read_b96/ds_write_b96 better choice +// for unaligned accesses? foreach vt = VReg_96.RegTypes in { defm : DSReadPat_mc <DS_READ_B96, vt, "load_local">; -} - -foreach vt = VReg_96.RegTypes in { defm : DSWritePat_mc <DS_WRITE_B96, vt, "store_local">; } -// For performance reasons, *do not* select ds_read_b128/ds_write_b128 in -// unaligned-access-mode. At lower alignments ds_read2_b64/ds_write2_b64 is -// always a better choice. +// For performance reasons, *do not* select ds_read_b128/ds_write_b128 for unaligned +// accesses. } // End SubtargetPredicate = HasUnalignedAccessMode |