aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Weaver <Tom.Weaver@Sony.com>2020-03-16 16:38:41 +0000
committerTom Weaver <Tom.Weaver@Sony.com>2020-03-16 16:38:41 +0000
commit09f4bdc03f891cbcf0c5633c8c7013eb0fbe626f (patch)
treebe15b94a48116ccc7223b8006a107ecf67b85883 /debuginfo-tests
parentMinor fix to a comment in CodeGenPrepare.cpp (diff)
downloadllvm-project-09f4bdc03f891cbcf0c5633c8c7013eb0fbe626f.tar.gz
llvm-project-09f4bdc03f891cbcf0c5633c8c7013eb0fbe626f.tar.bz2
llvm-project-09f4bdc03f891cbcf0c5633c8c7013eb0fbe626f.zip
[DexTer] Add step.UNKNOWN check for NoneType line numbers.
Summary: It's possible for an instance of the visual studio debugger to return a NoneType line number location when stepping during a debugging session. This patches teaches DexTer how to handle this particular case without crashing out. Reviewers: Orlando Differential revision: https://reviews.llvm.org/D75992
Diffstat (limited to 'debuginfo-tests')
-rw-r--r--debuginfo-tests/dexter/dex/dextIR/DextIR.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/debuginfo-tests/dexter/dex/dextIR/DextIR.py b/debuginfo-tests/dexter/dex/dextIR/DextIR.py
index 7638e8b4ab78..b82c2bab56de 100644
--- a/debuginfo-tests/dexter/dex/dextIR/DextIR.py
+++ b/debuginfo-tests/dexter/dex/dextIR/DextIR.py
@@ -102,6 +102,10 @@ class DextIR:
frame_step = self._get_prev_step_in_this_frame(step)
prev_step = frame_step if frame_step is not None else prev_step
+ # If we're missing line numbers to compare then the step kind has to be UNKNOWN.
+ if prev_step.current_location.lineno is None or step.current_location.lineno is None:
+ return StepKind.UNKNOWN
+
# We're in the same func as prev step, check lineo.
if prev_step.current_location.lineno > step.current_location.lineno:
return StepKind.VERTICAL_BACKWARD