aboutsummaryrefslogtreecommitdiff
path: root/llvm
diff options
context:
space:
mode:
authorHans Wennborg <hans@chromium.org>2020-09-28 15:35:01 +0200
committerHans Wennborg <hans@chromium.org>2020-09-28 15:35:06 +0200
commiteb83b551d3eb08cf472fe6307fe3809a8005b2cc (patch)
treec921699fdc7c34cab4ba2e5fb3f19a5a88205c3e /llvm
parent[LLVM-C] Turn a ShuffleVector Constant Into a Getter. (diff)
downloadllvm-project-eb83b551d3eb08cf472fe6307fe3809a8005b2cc.tar.gz
llvm-project-eb83b551d3eb08cf472fe6307fe3809a8005b2cc.tar.bz2
llvm-project-eb83b551d3eb08cf472fe6307fe3809a8005b2cc.zip
Fix mysterious failure of SupportTests FileCheckTest.Binopllvmorg-11.0.0-rc4
The test would fail in no-asserts release builds using MSVC for 64-bit Windows: Unexpected error message: TestBuffer:1:1: error: implicit format conflict between 'FOO' (%u) and '18\0' (%x), need an explicit format specifier Error message(s) not found: {implicit format conflict between 'FOO' (%u) and 'BAZ' (%x), need an explicit format specifier} It seems a string from a previous test case is finding its way into the latter one. This doesn't reproduce on master anymore after 998709b7d, so let's just hack around it here for the branch.
Diffstat (limited to 'llvm')
-rw-r--r--llvm/unittests/Support/FileCheckTest.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/llvm/unittests/Support/FileCheckTest.cpp b/llvm/unittests/Support/FileCheckTest.cpp
index 92975dcd76b7..a4591bc319bb 100644
--- a/llvm/unittests/Support/FileCheckTest.cpp
+++ b/llvm/unittests/Support/FileCheckTest.cpp
@@ -714,6 +714,7 @@ TEST_F(FileCheckTest, Binop) {
Value = Binop.eval();
expectUndefErrors({"FOO", "BAR"}, Value.takeError());
+ {
// Literal + Variable has format of variable.
ExprStr = bufferize(SM, "FOO+18");
FooStr = ExprStr.take_front(3);
@@ -736,6 +737,7 @@ TEST_F(FileCheckTest, Binop) {
ImplicitFormat = Binop.getImplicitFormat(SM);
ASSERT_THAT_EXPECTED(ImplicitFormat, Succeeded());
EXPECT_EQ(*ImplicitFormat, ExpressionFormat::Kind::Unsigned);
+ }
// Variables with different implicit format conflict.
ExprStr = bufferize(SM, "FOO+BAZ");