diff options
| author |   John Helmert III <ajak@gentoo.org> | 2023-12-17 20:23:27 -0800 |
|---|---|---|
| committer | John Helmert III <ajak@gentoo.org> | 2023-12-17 20:24:14 -0800 |
| commit | f86c0e7ce4d0bd5558e4ac7c10b3b20fb39f4d0a (patch) | |
| tree | ef4c4b37e99fbfa3d540f811cd6aaf40898f77aa | |
| parent | test_views: add basic autoglsa testing from client's perspective (diff) | |
| download | glsamaker-f86c0e7ce4d0bd5558e4ac7c10b3b20fb39f4d0a.tar.gz glsamaker-f86c0e7ce4d0bd5558e4ac7c10b3b20fb39f4d0a.tar.bz2 glsamaker-f86c0e7ce4d0bd5558e4ac7c10b3b20fb39f4d0a.zip | |
views: edit_glsa: oops, guard against empty error
And add a trivial test.
Signed-off-by: John Helmert III <ajak@gentoo.org>
| -rw-r--r-- | glsamaker/views.py | 4 | ||||
| -rw-r--r-- | test/test_views.py | 12 |
2 files changed, 15 insertions, 1 deletions
diff --git a/glsamaker/views.py b/glsamaker/views.py index d43f43f..fd4a822 100644 --- a/glsamaker/views.py +++ b/glsamaker/views.py @@ -253,8 +253,10 @@ def edit_glsa(glsa_id=None): return redirect("/drafts") if glsa_id: + error_bugs = [] # get errors from newbugs if present - error_bugs = request.args.get("error_bugs").split(",") + if "error_bugs" in request.args: + error_bugs = request.args.get("error_bugs").split(",") return render_template( "edit_glsa.html", diff --git a/test/test_views.py b/test/test_views.py index feb5d54..7d644a9 100644 --- a/test/test_views.py +++ b/test/test_views.py @@ -1,3 +1,4 @@ +import uuid from unittest.mock import MagicMock import pytest @@ -75,3 +76,14 @@ def test_newbugs(app, auth): ) assert response.status_code == 200 + + +def test_edit_glsa(app, auth, db): + glsa = GLSA() + glsa.draft = True + glsa.glsa_id = str(uuid.uuid4()) + db.session.merge(glsa) + + response = auth.get(f"/edit_glsa/{db.session.query(GLSA).first().glsa_id}") + + assert response.status_code == 200 |