diff options
Diffstat (limited to '0071-argo-Remove-reachable-ASSERT_UNREACHABLE.patch')
| -rw-r--r-- | 0071-argo-Remove-reachable-ASSERT_UNREACHABLE.patch | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/0071-argo-Remove-reachable-ASSERT_UNREACHABLE.patch b/0071-argo-Remove-reachable-ASSERT_UNREACHABLE.patch new file mode 100644 index 0000000..d1563bd --- /dev/null +++ b/0071-argo-Remove-reachable-ASSERT_UNREACHABLE.patch @@ -0,0 +1,41 @@ +From 916668baf9252ac30260e3394278a098712c5d34 Mon Sep 17 00:00:00 2001 +From: Jason Andryuk <jandryuk@gmail.com> +Date: Mon, 31 Oct 2022 13:32:59 +0100 +Subject: [PATCH 071/126] argo: Remove reachable ASSERT_UNREACHABLE + +I observed this ASSERT_UNREACHABLE in partner_rings_remove consistently +trip. It was in OpenXT with the viptables patch applied. + +dom10 shuts down. +dom7 is REJECTED sending to dom10. +dom7 shuts down and this ASSERT trips for dom10. + +The argo_send_info has a domid, but there is no refcount taken on +the domain. Therefore it's not appropriate to ASSERT that the domain +can be looked up via domid. Replace with a debug message. + +Signed-off-by: Jason Andryuk <jandryuk@gmail.com> +Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com> +master commit: 197f612b77c5afe04e60df2100a855370d720ad7 +master date: 2022-10-14 14:45:41 +0100 +--- + xen/common/argo.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/xen/common/argo.c b/xen/common/argo.c +index 49be715f638e..2b0d980d4bba 100644 +--- a/xen/common/argo.c ++++ b/xen/common/argo.c +@@ -1299,7 +1299,8 @@ partner_rings_remove(struct domain *src_d) + ASSERT_UNREACHABLE(); + } + else +- ASSERT_UNREACHABLE(); ++ argo_dprintk("%pd has entry for stale partner d%u\n", ++ src_d, send_info->id.domain_id); + + if ( dst_d ) + rcu_unlock_domain(dst_d); +-- +2.37.4 + |