apply patch to fix #139320

(Portage version: 2.1.1_pre2-r6)

4 files changed, 197 insertions, 1 deletions

diff --git a/media-libs/libmms/ChangeLog b/media-libs/libmms/ChangeLog
index d0640df5f741..dff18f4711ec 100644
--- a/media-libs/libmms/ChangeLog
+++ b/media-libs/libmms/ChangeLog
@@ -1,6 +1,12 @@
 # ChangeLog for media-libs/libmms
 # Copyright 1999-2006 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/media-libs/libmms/ChangeLog,v 1.4 2006/04/27 23:08:23 marienz Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-libs/libmms/ChangeLog,v 1.5 2006/07/20 14:23:51 allanonjl Exp $
+
+*libmms-0.2-r1 (20 Jul 2006)
+
+  20 Jul 2006; John N. Laliberte <allanonjl@gentoo.org>
+  +files/libmms_0.2-7-cumulative.diff, +libmms-0.2-r1.ebuild:
+  apply patch to fix #139320
 
   27 Apr 2006; Marien Zwart <marienz@gentoo.org> files/digest-libmms-0.1,
   Manifest:
diff --git a/media-libs/libmms/files/digest-libmms-0.2-r1 b/media-libs/libmms/files/digest-libmms-0.2-r1
new file mode 100644
index 000000000000..a376980bc503
--- /dev/null
+++ b/media-libs/libmms/files/digest-libmms-0.2-r1
@@ -0,0 +1,3 @@
+MD5 7e7117f8a28b21ce11beb3d2816066ff libmms-0.2.tar.gz 337792
+RMD160 6622df753852c37cccd457c2f7dc242d6b39ce93 libmms-0.2.tar.gz 337792
+SHA256 68392f88a2c392b7e329eeda9b953c32fbb5a28b7ab9eb8f55a8b3bdd4570774 libmms-0.2.tar.gz 337792
diff --git a/media-libs/libmms/files/libmms_0.2-7-cumulative.diff b/media-libs/libmms/files/libmms_0.2-7-cumulative.diff
new file mode 100644
index 000000000000..63a4c13aefc1
--- /dev/null
+++ b/media-libs/libmms/files/libmms_0.2-7-cumulative.diff
@@ -0,0 +1,144 @@
+--- libmms-0.2.orig/src/mms.c
++++ libmms-0.2/src/mms.c
+@@ -144,7 +144,7 @@
+   int           stream_types[ASF_MAX_NUM_STREAMS];
+   off_t         start_packet_seq; /* for live streams != 0, need to keep it around */
+   int           need_discont; /* whether we need to set start_packet_seq */
+-  int           asf_packet_len;
++  uint32_t      asf_packet_len;
+   uint64_t      file_len;
+   char          guid[37];
+   uint32_t      bitrates[ASF_MAX_NUM_STREAMS];
+@@ -477,7 +477,7 @@
+ }
+ 
+ static void string_utf16(iconv_t url_conv, char *dest, char *src, int len) {
+-    memset(dest, 0, 1000);
++    memset(dest, 0, 2 * len);
+ 
+     if (url_conv == (iconv_t)-1) {
+       int i;
+@@ -503,7 +503,7 @@
+ static void string_utf16(int unused, char *dest, char *src, int len) {
+   int i;
+ 
+-  memset (dest, 0, 1000);
++  memset (dest, 0, 2 * len);
+ 
+   for (i = 0; i < len; i++) {
+     dest[i * 2] = src[i];
+@@ -539,13 +539,17 @@
+       goto error;
+     
+     header->packet_len = LE_32(this->buf + 8) + 4;
++    if (header->packet_len > BUF_SIZE - 12) {
++        header->packet_len = 0;
++        goto error;
++    }
+     lprintf("mms command\n");
+     packet_type = MMS_PACKET_COMMAND;
+   } else {
+     header->packet_seq     = LE_32(this->buf);
+     header->packet_id_type = this->buf[4];
+     header->flags          = this->buf[5];
+-    header->packet_len     = LE_16(this->buf + 6) - 8;
++    header->packet_len     = (LE_16(this->buf + 6) - 8) & 0xffff;
+     if (header->packet_id_type == ASF_HEADER_PACKET_ID_TYPE) {
+       lprintf("asf header\n");
+       packet_type = MMS_PACKET_ASF_HEADER;
+@@ -674,6 +678,11 @@
+         break;
+       case MMS_PACKET_ASF_HEADER:
+       case MMS_PACKET_ASF_PACKET:
++        if (header.packet_len + this->asf_header_len > ASF_HEADER_LEN) {
++            lprintf( "***LOG:*** -- "
++                     "libmms: asf packet too large\n");
++            return 0;
++        }
+         len = io_read(io,  this->s,
+                               this->asf_header + this->asf_header_len, header.packet_len);
+         if (len != header.packet_len) {
+@@ -720,6 +729,12 @@
+       case GUID_ASF_FILE_PROPERTIES:
+ 
+         this->asf_packet_len = LE_32(this->asf_header + i + 92 - 24);
++        if (this->asf_packet_len > BUF_SIZE) {
++          this->asf_packet_len = 0;
++          lprintf( "***LOG:*** -- "
++                   "libmms: asf packet len too large\n");
++          break;
++        }
+         this->file_len       = LE_64(this->asf_header + i + 40 - 24);
+         lprintf ("file object, packet length = %d (%d)\n",
+                  this->asf_packet_len, LE_32(this->asf_header + i + 96 - 24));
+@@ -1420,8 +1435,20 @@
+ 
+         /* explicit padding with 0 */
+         lprintf("padding: %d bytes\n", this->asf_packet_len - header.packet_len);
+-        memset(this->buf + header.packet_len, 0, this->asf_packet_len - header.packet_len);
+-        this->buf_size = this->asf_packet_len;
++	{
++	  char *base  = (char *)(this->buf);
++	  char *start = base + header.packet_len;
++	  char *end   = start + this->asf_packet_len - header.packet_len;
++	  if ((start > base) && (start < (base+BUF_SIZE-1)) &&
++	      (start < end)  && (end < (base+BUF_SIZE-1))) {
++	    memset(this->buf + header.packet_len, 0, this->asf_packet_len - header.packet_len);
++ 	  }
++	  if (this->asf_packet_len > BUF_SIZE) {
++            this->buf_size = BUF_SIZE;
++          } else {
++            this->buf_size = this->asf_packet_len;
++          }
++	}
+       }
+       break;
+   }
+--- libmms-0.2.orig/src/mmsh.c
++++ libmms-0.2/src/mmsh.c
+@@ -184,7 +184,7 @@
+   int           num_stream_ids;
+   int           stream_ids[ASF_MAX_NUM_STREAMS];
+   int           stream_types[ASF_MAX_NUM_STREAMS];
+-  int           packet_length;
++  uint32_t      packet_length;
+   int64_t       file_length;
+   char          guid[37];
+   uint32_t      bitrates[ASF_MAX_NUM_STREAMS];
+@@ -604,6 +604,10 @@
+       case GUID_ASF_FILE_PROPERTIES:
+ 
+         this->packet_length = LE_32(this->asf_header + i + 92 - 24);
++        if (this->packet_length > CHUNK_SIZE) {
++          this->packet_length = 0;
++          break;
++        }
+         this->file_length   = LE_64(this->asf_header + i + 40 - 24);
+         lprintf ("file object, packet length = %d (%d)\n",
+ 		 this->packet_length, LE_32(this->asf_header + i + 96 - 24));
+@@ -1054,9 +1058,22 @@
+ 		 this->chunk_length, this->packet_length);
+ 	return 0;
+       }
+-      memset(this->buf + this->chunk_length, 0,
+-             this->packet_length - this->chunk_length);
+-      this->buf_size = this->packet_length;
++
++      {
++	char *base  = (char *)(this->buf);
++	char *start = base + this->chunk_length;
++	char *end   = start + this->packet_length - this->chunk_length;
++	if ((start > base) && (start < (base+CHUNK_SIZE-1)) &&
++	    (start < end)  && (end < (base+CHUNK_SIZE-1))) {
++	  memset(start, 0,
++		 this->packet_length - this->chunk_length);
++	}
++	if (this->packet_length > CHUNK_SIZE) {
++	  this->buf_size = CHUNK_SIZE;
++	} else {
++	  this->buf_size = this->packet_length;
++	}
++      }
+       return 1;
+     } else {
+       lprintf ("mmsh: read error, %d != %d\n", len, this->chunk_length);
diff --git a/media-libs/libmms/libmms-0.2-r1.ebuild b/media-libs/libmms/libmms-0.2-r1.ebuild
new file mode 100644
index 000000000000..c3c9c9967675
--- /dev/null
+++ b/media-libs/libmms/libmms-0.2-r1.ebuild
@@ -0,0 +1,43 @@
+# Copyright 1999-2006 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+# $Header: /var/cvsroot/gentoo-x86/media-libs/libmms/libmms-0.2-r1.ebuild,v 1.1 2006/07/20 14:23:51 allanonjl Exp $
+
+inherit eutils
+
+DESCRIPTION="Common library for accessing Microsoft Media Server (MMS) media streaming protocol"
+
+HOMEPAGE="http://libmms.sourceforge.net"
+SRC_URI="mirror://sourceforge/${PN}/${P}.tar.gz"
+LICENSE="LGPL-2.1"
+
+SLOT="0"
+KEYWORDS="~x86"
+IUSE=""
+
+RDEPEND=">=dev-libs/glib-2"
+
+DEPEND="${RDEPEND}
+	dev-util/pkgconfig"
+
+src_unpack() {
+	unpack "${A}"
+	cd "${S}"
+
+	# patch for bug #139320
+	epatch "${FILESDIR}"/${PN}_0.2-7-cumulative.diff
+}
+
+src_compile() {
+
+	econf || die
+	emake || die "emake failed"
+
+}
+
+src_install() {
+
+	make DESTDIR=${D} install || die
+
+	dodoc AUTHORS ChangeLog NEWS README* TODO
+
+}