Add backported patches for the ifnet plug-in.

(Portage version: 2.1.9.49/cvs/Linux x86_64)

1 files changed, 158 insertions, 0 deletions

diff --git a/net-misc/networkmanager/files/networkmanager-0.8.4.0-ifnet-smarter-write.patch b/net-misc/networkmanager/files/networkmanager-0.8.4.0-ifnet-smarter-write.patch
new file mode 100644
index 000000000000..ff4c1f253677
--- /dev/null
+++ b/net-misc/networkmanager/files/networkmanager-0.8.4.0-ifnet-smarter-write.patch
@@ -0,0 +1,158 @@
+From 776fafc133e18df48dc92a717c662e1b2858567e Mon Sep 17 00:00:00 2001
+From: Mu Qiao <qiaomuf@gentoo.org>
+Date: Fri, 25 Feb 2011 16:25:07 +0000
+Subject: [PATCH 3/3] Won't write when nothing changed
+ Signed-off-by: Mu Qiao <qiaomuf@gentoo.org>
+ Make log less excessive, accept non-alnum ssid (bug #356337)
+
+Signed-off-by: Mu Qiao <qiaomuf@gentoo.org>
+---
+ system-settings/plugins/ifnet/connection_parser.c |   33 +++++++++-----------
+ system-settings/plugins/ifnet/net_parser.c        |    8 ++++-
+ system-settings/plugins/ifnet/plugin.c            |    4 --
+ system-settings/plugins/ifnet/wpa_parser.c        |    7 +++-
+ 4 files changed, 26 insertions(+), 26 deletions(-)
+
+diff --git a/system-settings/plugins/ifnet/connection_parser.c b/system-settings/plugins/ifnet/connection_parser.c
+index 9b5ddc1..4ac2173 100644
+--- a/system-settings/plugins/ifnet/connection_parser.c
++++ b/system-settings/plugins/ifnet/connection_parser.c
+@@ -55,9 +55,16 @@ update_connection_id (NMConnection * connection, gchar * conn_name)
+ 	gchar *idstr = NULL;
+ 	gchar *uuid_base = NULL;
+ 	gchar *uuid = NULL;
++	int name_len;
+ 	NMSettingConnection *setting;
+ 
+-	idstr = g_strdup_printf ("%s (%s)", get_prefix (), conn_name);
++	name_len = strlen (conn_name);
++	if ((name_len > 2) && (g_str_has_prefix (conn_name, "0x"))) {
++		gchar * conn_name_printable = utils_hexstr2bin (conn_name + 2, name_len - 2);
++		idstr = g_strdup_printf ("%s (%s)", get_prefix (), conn_name_printable);
++		g_free (conn_name_printable);
++	} else
++		idstr = g_strdup_printf ("%s (%s)", get_prefix (), conn_name);
+ 	uuid_base = idstr;
+ 	uuid = nm_utils_uuid_generate_from_string (uuid_base);
+ 	setting =
+@@ -627,23 +634,13 @@ make_ip4_setting (NMConnection * connection, gchar * conn_name, GError ** error)
+ 				g_object_set (ip4_setting,
+ 					      NM_SETTING_IP4_CONFIG_IGNORE_AUTO_ROUTES,
+ 					      TRUE, NULL);
+-			if (nm_setting_ip4_config_add_address
+-			    (ip4_setting, ip4_addr)) {
+-				PLUGIN_PRINT (IFNET_PLUGIN_NAME,
+-					      "new address: %d", iblock->ip);
+-				PLUGIN_PRINT (IFNET_PLUGIN_NAME,
+-					      "ipv4 addresses count: %d",
+-					      nm_setting_ip4_config_get_num_addresses
+-					      (ip4_setting));
+-			} else {
+-				PLUGIN_WARN (IFNET_PLUGIN_NAME,
+-					     "ignoring duplicate IP4 address");
+-			}
++			if (!nm_setting_ip4_config_add_address (ip4_setting, ip4_addr))
++				PLUGIN_WARN (IFNET_PLUGIN_NAME, 
++						"ignoring duplicate IP4 address");
+ 			nm_ip4_address_unref (ip4_addr);
+ 			current_iblock = iblock;
+ 			iblock = iblock->next;
+ 			destroy_ip_block (current_iblock);
+-
+ 		}
+ 		g_object_set (ip4_setting,
+ 			      NM_SETTING_IP4_CONFIG_METHOD,
+@@ -2276,11 +2273,12 @@ write_wireless_setting (NMConnection * connection,
+ 		return FALSE;
+ 	}
+ 
+-	/* If the SSID contains any non-printable characters, we need to use the
+-	 * hex notation of the SSID instead.
++	/* If the SSID contains any non-alnum characters, we need to use 
++	 * the hex notation of the SSID instead. (Because openrc doesn't 
++	 * support these characters, see bug #356337)
+ 	 */
+ 	for (i = 0; i < ssid->len; i++) {
+-		if (!isprint (ssid->data[i])) {
++		if (!isalnum (ssid->data[i])) {
+ 			hex_ssid = TRUE;
+ 			break;
+ 		}
+@@ -2487,7 +2485,6 @@ write_ip4_setting (NMConnection * connection, gchar * conn_name,
+ 		ifnet_set_data (conn_name, "config", "dhcp");
+ 
+ 	/* DNS Servers */
+-	ifnet_set_data (conn_name, "dns_servers", NULL);
+ 	num = nm_setting_ip4_config_get_num_dns (s_ip4);
+ 	if (num > 0) {
+ 		dns = g_string_new (NULL);
+diff --git a/system-settings/plugins/ifnet/net_parser.c b/system-settings/plugins/ifnet/net_parser.c
+index de2db8a..57f3688 100644
+--- a/system-settings/plugins/ifnet/net_parser.c
++++ b/system-settings/plugins/ifnet/net_parser.c
+@@ -411,12 +411,16 @@ ifnet_set_data (gchar * conn_name, gchar * key, gchar * value)
+ 	}
+ 	/* Remove existing key value pair */
+ 	if (g_hash_table_lookup_extended (conn, key, &orin_key, &orin_value)) {
+-		if (new_value && !strcmp (orin_value, new_value))
++		if (new_value && !strcmp (orin_value, new_value)){
++			g_free (new_value);
+ 			return;
++		}
+ 		g_hash_table_remove (conn, orin_key);
+ 		g_free (orin_key);
+ 		g_free (orin_value);
+-	}
++	/* old key/value doesn't exist but new value is NULL  */
++	} else if (!value)
++		return;
+ 	if (new_value)
+ 		g_hash_table_insert (conn, g_strdup (key), new_value);
+ 	net_parser_data_changed = TRUE;
+diff --git a/system-settings/plugins/ifnet/plugin.c b/system-settings/plugins/ifnet/plugin.c
+index 94f9e79..3952e91 100644
+--- a/system-settings/plugins/ifnet/plugin.c
++++ b/system-settings/plugins/ifnet/plugin.c
+@@ -91,8 +91,6 @@ update_system_hostname (gpointer config)
+ {
+ 	SCPluginIfnetPrivate *priv = SC_PLUGIN_IFNET_GET_PRIVATE (config);
+ 
+-	PLUGIN_PRINT (IFNET_PLUGIN_NAME, "Updating hostname");
+-
+ 	if (priv->hostname)
+ 		g_free (priv->hostname);
+ 	priv->hostname = read_hostname (IFNET_SYSTEM_HOSTNAME_FILE);
+@@ -184,8 +182,6 @@ monitor_file_changes (const char *filename,
+ 				   info);
+ 		g_signal_connect (monitor, "changed", G_CALLBACK (file_changed),
+ 				  info);
+-		PLUGIN_PRINT (IFNET_PLUGIN_NAME, "Monitoring %s", filename);
+-
+ 	} else
+ 		PLUGIN_WARN (IFNET_PLUGIN_NAME,
+ 			     "Monitoring %s failed, error: %s", filename,
+diff --git a/system-settings/plugins/ifnet/wpa_parser.c b/system-settings/plugins/ifnet/wpa_parser.c
+index 42c52c3..338c338 100644
+--- a/system-settings/plugins/ifnet/wpa_parser.c
++++ b/system-settings/plugins/ifnet/wpa_parser.c
+@@ -463,12 +463,15 @@ wpa_set_data (gchar * ssid, gchar * key, gchar * value)
+ 	/* Remove old key value pairs */
+ 	if (g_hash_table_lookup_extended
+ 	    (security, key, &orig_key, &orig_value)) {
+-		if (new_value && !strcmp(orig_value, new_value))
++		if (new_value && !strcmp(orig_value, new_value)){
++			g_free (new_value);
+ 			return;
++		}
+ 		g_hash_table_remove (security, orig_key);
+ 		g_free (orig_key);
+ 		g_free (orig_value);
+-	}
++	} else if (!value)
++		return;
+ 
+ 	/* Add new key value */
+ 	if (new_value)
+-- 
+1.7.3.4
+