diff options
| author |   Lennart Poettering <lennart@poettering.net> | 2014-10-27 18:09:07 +0100 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2014-10-27 18:09:26 +0100 |
| commit | 7f8bf08f9036de419ad14c55b61eda74c6659d3a (patch) | |
| tree | 35beb62a17ae225d211434111958607c3393e392 | |
| parent | calendarspec: parse 'quarterly' and 'semi-annually' as shortcuts (diff) | |
| download | systemd-7f8bf08f9036de419ad14c55b61eda74c6659d3a.tar.gz systemd-7f8bf08f9036de419ad14c55b61eda74c6659d3a.tar.bz2 systemd-7f8bf08f9036de419ad14c55b61eda74c6659d3a.zip | |
CODING_STYLE: don't clobber arguments on failure
| -rw-r--r-- | CODING_STYLE | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/CODING_STYLE b/CODING_STYLE index 598d241b2..4439ee609 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -182,7 +182,11 @@ is_main_thread() to detect whether the calling thread is the main thread. -- Option parsing: +- Command line option parsing: - Do not print full help() on error, be specific about the error. - Do not print messages to stdout on error. - Do not POSIX_ME_HARDER unless necessary, i.e. avoid "+" in option string. + +- Do not write functions that clobber call-by-reference variables on + failure. Use temporary variables for these cases and change the + passed in variables only on success. |