diff options
| author |   Simon McVittie <simon.mcvittie@collabora.co.uk> | 2015-06-17 11:23:46 +0100 |
|---|---|---|
| committer | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2015-06-17 11:23:46 +0100 |
| commit | 11c9f1e48a683fb2e78ee531016099d567baa19a (patch) | |
| tree | bdb4ab47e2a7334ff333622eb581fcf78240fd3d /CODING_STYLE | |
| parent | Merge pull request #228 from teg/tmpfiles-btrfs-notdir (diff) | |
| download | systemd-11c9f1e48a683fb2e78ee531016099d567baa19a.tar.gz systemd-11c9f1e48a683fb2e78ee531016099d567baa19a.tar.bz2 systemd-11c9f1e48a683fb2e78ee531016099d567baa19a.zip | |
Stop talking about the "XDG" version of basename()
XDG refers to X Desktop Group, a former name for freedesktop.org.
This group is responsible for specifications like basedirs,
.desktop files and icon naming, but as far as I know, it has never
tried to redefine basename().
I think these references were meant to say XPG (X/Open Portability
Guide), a precursor of POSIX. POSIX is better-known and less easily
confused with XDG, and is how the basename(3) man page describes
the libgen.h version of basename().
The other version of basename() is glibc-specific and is described
in basename(3) as "the GNU version"; specifically mention that
version, to disambiguate.
Diffstat (limited to 'CODING_STYLE')
| -rw-r--r-- | CODING_STYLE | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/CODING_STYLE b/CODING_STYLE index bdec988ce..dbadfbdb5 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -210,11 +210,12 @@ c) recvmsg() must get MSG_CMSG_CLOEXEC set d) F_DUPFD_CLOEXEC should be used instead of F_DUPFD, and so on -- We never use the XDG version of basename(). glibc defines it in - libgen.h. The only reason to include that file is because dirname() +- We never use the POSIX version of basename() (which glibc defines it in + libgen.h), only the GNU version (which glibc defines in string.h). + The only reason to include libgen.h is because dirname() is needed. Everytime you need that please immediately undefine basename(), and add a comment about it, so that no code ever ends up - using the XDG version! + using the POSIX version! - Use the bool type for booleans, not integers. One exception: in public headers (i.e those in src/systemd/sd-*.h) use integers after all, as "bool" |