diff options
author | Mart Raudsepp <leio@gentoo.org> | 2008-09-22 09:56:54 +0300 |
---|---|---|
committer | Mart Raudsepp <leio@gentoo.org> | 2008-09-22 09:56:54 +0300 |
commit | 57e9222e8ce77331fdf5ef969e31ca86d579e985 (patch) | |
tree | ade7d7afa39761b84291131e56ccad57fc17ff72 | |
parent | Fix packages with name mapping to report correct status (diff) | |
download | gentoo-bumpchecker-57e9222e8ce77331fdf5ef969e31ca86d579e985.tar.gz gentoo-bumpchecker-57e9222e8ce77331fdf5ef969e31ca86d579e985.tar.bz2 gentoo-bumpchecker-57e9222e8ce77331fdf5ef969e31ca86d579e985.zip |
Simplify Package.parse_mm() method by making use of builtin string methods
Shortens it from 17 lines to 1 line by using str.split and str.join instead
of the unwieldy hand-rolled dot finding string walking method.
There is no worry for performance here as version numbers won't be long
for string walking till the end being of concern.
-rw-r--r-- | modules/package_module.py | 18 |
1 files changed, 1 insertions, 17 deletions
diff --git a/modules/package_module.py b/modules/package_module.py index c86e44f..ece6798 100644 --- a/modules/package_module.py +++ b/modules/package_module.py @@ -57,23 +57,7 @@ class Package: print "Error, " + raw_string + " is not a valid package!" def parse_mm(self, version): - majorminor = "" - - firstdot = version.find(".") - if 0 < firstdot: - major = version[:firstdot] - majorminor += major - - version = version[firstdot+1:] - seconddot = version.find(".") - if 0 < seconddot: - minor = version[:seconddot] - majorminor = majorminor + "." + minor - elif 0 > seconddot: - # This means there is no second dot, something like, gtk-doc-1.4 - majorminor = majorminor + "." + version - - return majorminor + return '.'.join(version.split('.')[0:2]) def print_info(self): print "Name: " + str(self.name) |