aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFabian Groffen <grobian@gentoo.org>2022-02-12 19:15:40 +0100
committerFabian Groffen <grobian@gentoo.org>2022-02-12 19:15:40 +0100
commit219ba2dd9f748c6065c6485020f7de56623e1bc9 (patch)
treea9980b752507132fa5cd9c00c897372e0a8c6923 /qmerge.c
parentqlop: fix Coverity condition always true CID 248869 (diff)
downloadportage-utils-219ba2dd9f748c6065c6485020f7de56623e1bc9.tar.gz
portage-utils-219ba2dd9f748c6065c6485020f7de56623e1bc9.tar.bz2
portage-utils-219ba2dd9f748c6065c6485020f7de56623e1bc9.zip
qmerge: fix Coverity file descriptor leak CID 207952
Leak would happen when opening file succeed, but statting it would fail. Unlikely, but better to take into account anyway. Signed-off-by: Fabian Groffen <grobian@gentoo.org>
Diffstat (limited to 'qmerge.c')
-rw-r--r--qmerge.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/qmerge.c b/qmerge.c
index a64447eb..80affdba 100644
--- a/qmerge.c
+++ b/qmerge.c
@@ -1693,8 +1693,9 @@ unlink_empty(const char *buf)
if (fd != -1 && stat(buf, &st) != -1) {
if (st.st_size == 0)
ret = unlink(buf);
- close(fd);
}
+ if (fd != -1)
+ close(fd);
return ret;
}