dev-db/postgresql-client: added some comments

svn path=/experimental/; revision=227

6 files changed, 34 insertions, 20 deletions

diff --git a/dev-db/postgresql-client/Manifest b/dev-db/postgresql-client/Manifest
index 3a5c6fc..f1a8492 100644
--- a/dev-db/postgresql-client/Manifest
+++ b/dev-db/postgresql-client/Manifest
@@ -76,26 +76,26 @@ DIST postgresql-opt-7.4.16.tar.bz2 333683 RMD160 fec0e9b68c4868f4e2b85c002103089
 DIST postgresql-opt-8.0.12.tar.bz2 134790 RMD160 be0d57de5000296bfd5b64685f4d4ef81edea347 SHA1 bd26e2cce6ea7b486e29bc983ee76cfb0551f32b SHA256 ceaf90195860694487918032c19e0a11f991d74c77838cac2ea827d6c85f54da
 DIST postgresql-opt-8.1.8.tar.bz2 144643 RMD160 2a31e70be662ee6753bcc8e712ea5a693079f692 SHA1 df4cf9481a6272d5a33b07f8343e88fe8f1350a4 SHA256 ffcc9519a7a697b370630ab1afb1280d3d9e62a25a7904291153d0de6fca6750
 DIST postgresql-opt-8.2.3.tar.bz2 167549 RMD160 f9dad95527f22aaef809b52acbde2b80b0a1ed5a SHA1 ff37f7a5eaacdaaa4993023554ed180b636b1fcf SHA256 fc82d271c988b27515735db463e6f656f0417104f8f0cabfda5c515e15b1876e
-EBUILD postgresql-client-7.3.18.ebuild 2157 RMD160 a6dd70a474178d003b170084aa484cc8c270969c SHA1 28abe0c201128172521d7a819d6613777808a05a SHA256 d8e647f80522b6852ea79ba330aa319257d89fbe3cdef96fc2ab71885a3f48a8
-MD5 695fc2e6324107a9a213f6eb4b7ad38a postgresql-client-7.3.18.ebuild 2157
-RMD160 a6dd70a474178d003b170084aa484cc8c270969c postgresql-client-7.3.18.ebuild 2157
-SHA256 d8e647f80522b6852ea79ba330aa319257d89fbe3cdef96fc2ab71885a3f48a8 postgresql-client-7.3.18.ebuild 2157
-EBUILD postgresql-client-7.4.16.ebuild 2470 RMD160 2911617d3843aa7d76f88373869bffd765472b5c SHA1 54f7ebf6eca653e1a69501d7d6e9e0e24ada593e SHA256 d4398c1ff0de2b4b1cbe6bb91b6973af6c4a01dd79699b8a68264d40874cc194
-MD5 e9188ffbbbeea58f15075ce967dfa757 postgresql-client-7.4.16.ebuild 2470
-RMD160 2911617d3843aa7d76f88373869bffd765472b5c postgresql-client-7.4.16.ebuild 2470
-SHA256 d4398c1ff0de2b4b1cbe6bb91b6973af6c4a01dd79699b8a68264d40874cc194 postgresql-client-7.4.16.ebuild 2470
-EBUILD postgresql-client-8.0.12.ebuild 2753 RMD160 70cbbd937144bf1502efedb563af06194b93c8df SHA1 2e8429d3fdf9a5f484582a6230e83dfdef30578f SHA256 cfb054f169aa156a0a8569cb6f54e54c0852004ac631918d57b84073af22939d
-MD5 96aa06b9b2ec282361ab001933470799 postgresql-client-8.0.12.ebuild 2753
-RMD160 70cbbd937144bf1502efedb563af06194b93c8df postgresql-client-8.0.12.ebuild 2753
-SHA256 cfb054f169aa156a0a8569cb6f54e54c0852004ac631918d57b84073af22939d postgresql-client-8.0.12.ebuild 2753
-EBUILD postgresql-client-8.1.8.ebuild 2438 RMD160 23a37838228f1b8bc22f6206821e88ce8f51d955 SHA1 7b0258966cfbf1ba34208058115ec5372e40f174 SHA256 02edfda4432235fe337890a9409d06e7bf29c457c325ebdeca93595a9b1adba6
-MD5 1ce6989df26802954b26251154c50ff6 postgresql-client-8.1.8.ebuild 2438
-RMD160 23a37838228f1b8bc22f6206821e88ce8f51d955 postgresql-client-8.1.8.ebuild 2438
-SHA256 02edfda4432235fe337890a9409d06e7bf29c457c325ebdeca93595a9b1adba6 postgresql-client-8.1.8.ebuild 2438
-EBUILD postgresql-client-8.2.3.ebuild 2466 RMD160 c44ca85f39fa53684a750ea13e890bba2a11af74 SHA1 c5a08e68d65d5f252ca784dc23a448a3fc3622cd SHA256 41481eca13aced01246dbf779b0b31d7d20438236232f7a1457cd23ebdd422e7
-MD5 3c5236430933a5b8677c96fcb8beeb8f postgresql-client-8.2.3.ebuild 2466
-RMD160 c44ca85f39fa53684a750ea13e890bba2a11af74 postgresql-client-8.2.3.ebuild 2466
-SHA256 41481eca13aced01246dbf779b0b31d7d20438236232f7a1457cd23ebdd422e7 postgresql-client-8.2.3.ebuild 2466
+EBUILD postgresql-client-7.3.18.ebuild 2236 RMD160 044fd42b2a938ef7d53b452f35d936193cc248a1 SHA1 c60461e325f8cd7b339d321295f9d78b784de8c8 SHA256 d784d7459697dc00ae069740a378d207641973fa1fa2bdd589192921df416a7f
+MD5 25c3082165d9db3f8255c51b687de42e postgresql-client-7.3.18.ebuild 2236
+RMD160 044fd42b2a938ef7d53b452f35d936193cc248a1 postgresql-client-7.3.18.ebuild 2236
+SHA256 d784d7459697dc00ae069740a378d207641973fa1fa2bdd589192921df416a7f postgresql-client-7.3.18.ebuild 2236
+EBUILD postgresql-client-7.4.16.ebuild 2549 RMD160 4fdda86140d90cde3094decf410ec022cf3285e9 SHA1 0fa03d0d0fca5c2044e470b450aaa7092e314b22 SHA256 b8d5fe25549ece90ceaa56b087d9cb5d6df9e5c2479f4d52f5c28e1ceecb4555
+MD5 5eba504cb8ff645fc639391521acb157 postgresql-client-7.4.16.ebuild 2549
+RMD160 4fdda86140d90cde3094decf410ec022cf3285e9 postgresql-client-7.4.16.ebuild 2549
+SHA256 b8d5fe25549ece90ceaa56b087d9cb5d6df9e5c2479f4d52f5c28e1ceecb4555 postgresql-client-7.4.16.ebuild 2549
+EBUILD postgresql-client-8.0.12.ebuild 2832 RMD160 9e5c4135143ebf12d7ae285b9bb4f81429236920 SHA1 825907fb329374f6773f56c3ca4b7fa17f4ad7dd SHA256 93efb5300097e18d6bb534c1a774e6da80139dedbd10e47ef162f9e8294937e5
+MD5 8525c253134b99aaa3a8f6ce7b65cc59 postgresql-client-8.0.12.ebuild 2832
+RMD160 9e5c4135143ebf12d7ae285b9bb4f81429236920 postgresql-client-8.0.12.ebuild 2832
+SHA256 93efb5300097e18d6bb534c1a774e6da80139dedbd10e47ef162f9e8294937e5 postgresql-client-8.0.12.ebuild 2832
+EBUILD postgresql-client-8.1.8.ebuild 2517 RMD160 746a9485f70c0e169a08e56db2bb6552b53369d3 SHA1 5fdf23a4011dfc7e6c01b79cb7cd04ff3b185fde SHA256 9db543834e563feb3035ba4513714f6fca3770624420f4c3a2548b28a896fb0b
+MD5 093e4bcc4207256e071a0e9cc674493c postgresql-client-8.1.8.ebuild 2517
+RMD160 746a9485f70c0e169a08e56db2bb6552b53369d3 postgresql-client-8.1.8.ebuild 2517
+SHA256 9db543834e563feb3035ba4513714f6fca3770624420f4c3a2548b28a896fb0b postgresql-client-8.1.8.ebuild 2517
+EBUILD postgresql-client-8.2.3.ebuild 2762 RMD160 57327a65d811fc421ac78a5c194c694c57c47f3e SHA1 8d90788209a402469faf24d1d738f25c527b035e SHA256 c29884541c471a6e027a9cb1cbe8148538a22b08bdeb1015e15597b2ffdc9b1d
+MD5 8f93c9e58a44c0ae2aacd16ddb08789b postgresql-client-8.2.3.ebuild 2762
+RMD160 57327a65d811fc421ac78a5c194c694c57c47f3e postgresql-client-8.2.3.ebuild 2762
+SHA256 c29884541c471a6e027a9cb1cbe8148538a22b08bdeb1015e15597b2ffdc9b1d postgresql-client-8.2.3.ebuild 2762
 MD5 6f1763f9230bffd911a68f57646f286c files/digest-postgresql-client-7.3.18 542
 RMD160 4bbbd10cf2b08c8e4b629de86e2f170161ac8aa7 files/digest-postgresql-client-7.3.18 542
 SHA256 438acb827392b58a871dd39b519563b23d0db3ebb1817bc09accaeaa26ecd4fc files/digest-postgresql-client-7.3.18 542
diff --git a/dev-db/postgresql-client/postgresql-client-7.3.18.ebuild b/dev-db/postgresql-client/postgresql-client-7.3.18.ebuild
index 4458d11..fcc4e13 100644
--- a/dev-db/postgresql-client/postgresql-client-7.3.18.ebuild
+++ b/dev-db/postgresql-client/postgresql-client-7.3.18.ebuild
@@ -39,6 +39,8 @@ src_unpack() {
 src_compile() {
 	# TODO: test if PPC really cannot work with other CFLAGS settings
 	# use ppc && CFLAGS="-pipe -fsigned-char"
+
+	# eval is need to get along with pg_config quotation of space-rich entities.
 	eval ./configure "$(/usr/$(get_libdir)/postgresql-${SLOT}/bin/pg_config --configure)" \
 		|| die "configure failed"
 
diff --git a/dev-db/postgresql-client/postgresql-client-7.4.16.ebuild b/dev-db/postgresql-client/postgresql-client-7.4.16.ebuild
index 8cc3cdb..944d1b6 100644
--- a/dev-db/postgresql-client/postgresql-client-7.4.16.ebuild
+++ b/dev-db/postgresql-client/postgresql-client-7.4.16.ebuild
@@ -39,6 +39,8 @@ src_unpack() {
 src_compile() {
 	# TODO: test if PPC really cannot work with other CFLAGS settings
 	# use ppc && CFLAGS="-pipe -fsigned-char"
+
+	# eval is need to get along with pg_config quotation of space-rich entities.
 	eval ./configure "$(/usr/$(get_libdir)/postgresql-${SLOT}/bin/pg_config --configure)" \
 		|| die "configure failed"
 
diff --git a/dev-db/postgresql-client/postgresql-client-8.0.12.ebuild b/dev-db/postgresql-client/postgresql-client-8.0.12.ebuild
index 4acbe7a..ec34c2a 100644
--- a/dev-db/postgresql-client/postgresql-client-8.0.12.ebuild
+++ b/dev-db/postgresql-client/postgresql-client-8.0.12.ebuild
@@ -42,6 +42,8 @@ src_unpack() {
 src_compile() {
 	# TODO: test if PPC really cannot work with other CFLAGS settings
 	# use ppc && CFLAGS="-pipe -fsigned-char"
+
+	# eval is need to get along with pg_config quotation of space-rich entities.
 	eval econf "$(/usr/$(get_libdir)/postgresql-${SLOT}/bin/pg_config --configure)" \
 		|| die "configure failed"
 
diff --git a/dev-db/postgresql-client/postgresql-client-8.1.8.ebuild b/dev-db/postgresql-client/postgresql-client-8.1.8.ebuild
index f968c7a..7d0791e 100644
--- a/dev-db/postgresql-client/postgresql-client-8.1.8.ebuild
+++ b/dev-db/postgresql-client/postgresql-client-8.1.8.ebuild
@@ -42,6 +42,8 @@ src_unpack() {
 src_compile() {
 	# TODO: test if PPC really cannot work with other CFLAGS settings
 	# use ppc && CFLAGS="-pipe -fsigned-char"
+
+	# eval is need to get along with pg_config quotation of space-rich entities.
 	eval econf "$(/usr/$(get_libdir)/postgresql-${SLOT}/bin/pg_config --configure)" \
 		|| die "configure failed"
 
diff --git a/dev-db/postgresql-client/postgresql-client-8.2.3.ebuild b/dev-db/postgresql-client/postgresql-client-8.2.3.ebuild
index b3a6e19..438740e 100644
--- a/dev-db/postgresql-client/postgresql-client-8.2.3.ebuild
+++ b/dev-db/postgresql-client/postgresql-client-8.2.3.ebuild
@@ -42,6 +42,12 @@ src_unpack() {
 src_compile() {
 	# TODO: test if PPC really cannot work with other CFLAGS settings
 	# use ppc && CFLAGS="-pipe -fsigned-char"
+
+	# 1. threadsafety is disabled to avoid pulling in test tarball in absense of
+	# which configure would fail. The configure output in the large part goes
+	# unnoticed as the installed pgxs stuff is used instead.
+	# 2. eval is need to get along with pg_config quotation of space-rich
+	# entities.
 	eval econf "$(/usr/$(get_libdir)/postgresql-${SLOT}/bin/pg_config --configure)" \
 		--disable-thread-safety \
 		|| die "configure failed"