Some QA noted by c1pher

Package-Manager: portage-2.2_rc97/cvs/Linux x86_64

4 files changed, 29 insertions, 15 deletions

diff --git a/app-misc/splitvt/ChangeLog b/app-misc/splitvt/ChangeLog
index 30457f4527c1..74e2bc5c8a4f 100644
--- a/app-misc/splitvt/ChangeLog
+++ b/app-misc/splitvt/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for app-misc/splitvt
 # Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/ChangeLog,v 1.28 2010/10/23 22:34:45 c1pher Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/ChangeLog,v 1.29 2010/10/24 08:24:43 jlec Exp $
+
+  24 Oct 2010; Justin Lecher <jlec@gentoo.org> splitvt-1.6.6-r1.ebuild,
+  splitvt-1.6.6-r2.ebuild:
+  Some QA noted by c1pher
 
   23 Oct 2010; Dane Smith <c1pher@gentoo.org> splitvt-1.6.6-r2.ebuild:
   Stable x86 wrt bug 342143.
diff --git a/app-misc/splitvt/Manifest b/app-misc/splitvt/Manifest
index 976673ef2e63..0e5293f4d2da 100644
--- a/app-misc/splitvt/Manifest
+++ b/app-misc/splitvt/Manifest
@@ -1,8 +1,18 @@
+-----BEGIN PGP SIGNED MESSAGE-----
+Hash: SHA1
+
 AUX 1.6.6-ldflags.patch 1048 RMD160 051a20156acf4095c3a5eaac176bbf9dac81214a SHA1 211e8cb4dc59027bcdb653f0e726620be867b267 SHA256 7e10f795780db244f7283fea25d32ca1397bb0e526ba13bbf8b6623660319f67
 DIST splitvt-1.6.6.tar.gz 64797 RMD160 014a9990ef41414b8488e10c24354bfc9588c4f8 SHA1 8073f4998ae0d772deecc583b61ea7cb92f7186b SHA256 70a03afe3a43c7458c5fe0152c386f62669107e045b973aecc667259b1820937
 DIST splitvt_1.6.6-4.diff.gz 10911 RMD160 5f748d8cbd6a0d2a594ebfb07be30cf4d494fc98 SHA1 e520f52616177c37ea1713ffff3f998d8a671182 SHA256 987fd211755af843106379de5309e7a35a7a2a784ce0aca255a6bd8fa00d6a99
 DIST splitvt_1.6.6-7.diff.gz 11073 RMD160 e6abc940253dcaf8bb20849ec235cb0e164d3220 SHA1 6db1fae5a177a126e2f84426e0680113609f017c SHA256 083f6f3e0f35a10859270f29ca02605e04918bcd5bf2ad94d71f2b13283310e4
-EBUILD splitvt-1.6.6-r1.ebuild 1247 RMD160 38cf8bd96bb0580c16cc78cf5558bf15f42e1315 SHA1 9f3874856ef24a4b35149170a8f51eb984845b54 SHA256 40064dc55eeab726f919b03909c4d593d7617597ce19a43bd0f8ae5502d51080
-EBUILD splitvt-1.6.6-r2.ebuild 1345 RMD160 07b57bd7ee7fb8acd7e4b4a3465975b72e16f6a2 SHA1 2801af1625997063a91670e971fb40eecf66d94e SHA256 4d1dcbf3e6101e1380286ad380f7873f93e470408e95743e98d7756934654491
-MISC ChangeLog 3724 RMD160 1e4a87c9d8ad498b76ec3a847d1387e1361dfc1a SHA1 275ca95fcada3a178bbcd1e8750631323ad0e99b SHA256 cf0da6180886eca7094a987eb7cad1e5187869ee55b0d4bffe45e5284dfac26f
+EBUILD splitvt-1.6.6-r1.ebuild 1271 RMD160 9969155ef74f3960cb7b7099bfa7bf14cc4cef5a SHA1 9563f083e530ad99d6624f02f723e974e8681587 SHA256 8c3db113ab7bc6be2ad8b6d1d622d7e4347f91c562d153ecbdb048d042bc1733
+EBUILD splitvt-1.6.6-r2.ebuild 1316 RMD160 68210c8509b24da8a71765e5ed4b297c243c8b54 SHA1 35a6deec4aa8dda41892b0c18c7a2a9f135c0082 SHA256 68e482a384db0ccee633f4f59a3f76becc1813ef10e9057659a540a40696ad09
+MISC ChangeLog 3848 RMD160 320f3eb2617d87f00ba961e609d691b24787198d SHA1 2b73c3d2bf7f851d383d6d89a164cc4387ff1dd3 SHA256 88eb6691cbd088b62ceeee6b61edb2c3956ad7a24dddafb24f476f67e98e3a83
 MISC metadata.xml 166 RMD160 122e578c52fe3661ff8b8f1f574d8651916e3bf5 SHA1 5eb96c1efa4708676adcd6cad061b22caf9bdfe5 SHA256 064eb80cc86913e2a47d1088f1b0ebd5b64b5dab1c73d38b8501cd77891cfbbf
+-----BEGIN PGP SIGNATURE-----
+Version: GnuPG v2.0.16 (GNU/Linux)
+
+iEYEARECAAYFAkzD7VkACgkQgAnW8HDreRYnAQCgsYwH5eSk/Tjy2YysYWVI6bNV
+KYMAnRnUS1QSAm9e5IK9+9IYDA7oZOKA
+=pgag
+-----END PGP SIGNATURE-----
diff --git a/app-misc/splitvt/splitvt-1.6.6-r1.ebuild b/app-misc/splitvt/splitvt-1.6.6-r1.ebuild
index ae713ac16f50..0dba78b646c2 100644
--- a/app-misc/splitvt/splitvt-1.6.6-r1.ebuild
+++ b/app-misc/splitvt/splitvt-1.6.6-r1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2008 Gentoo Foundation
+# Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r1.ebuild,v 1.6 2008/03/29 13:29:04 coldwind Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r1.ebuild,v 1.7 2010/10/24 08:24:43 jlec Exp $
 
 inherit eutils toolchain-funcs
 
@@ -24,13 +24,13 @@ src_unpack() {
 	cd "${S}"
 	epatch "${WORKDIR}"/${MY_P}-${DEB_PL}.diff
 	sed -i -e "s:/usr/local/bin:${D}/usr/bin:g" \
-		-e "s:/usr/local/man/:${D}/usr/share/man/:g" config.c
+		-e "s:/usr/local/man/:${D}/usr/share/man/:g" config.c || die
 }
 
 src_compile() {
 	# upstream has their own weirdo configure script...
 	./configure || die "configure failed"
-	sed -i -e "s:-O2:${CFLAGS}:" -e "s:^CC = gcc:CC = $(tc-getCC):" Makefile
+	sed -i -e "s:-O2:${CFLAGS}:" -e "s:^CC = gcc:CC = $(tc-getCC):" Makefile || die
 	emake || die "emake failed"
 }
 
@@ -38,6 +38,6 @@ src_install() {
 	dodir /usr/bin /usr/share/man/man1/
 	make install || die "make install failed"
 	fperms 755 /usr/bin/xsplitvt
-	dodoc ANNOUNCE BLURB CHANGES NOTES README TODO
-	doman splitvt.1
+	dodoc ANNOUNCE BLURB CHANGES NOTES README TODO || die
+	doman splitvt.1 || die
 }
diff --git a/app-misc/splitvt/splitvt-1.6.6-r2.ebuild b/app-misc/splitvt/splitvt-1.6.6-r2.ebuild
index b20a8ef8fc48..757febd94780 100644
--- a/app-misc/splitvt/splitvt-1.6.6-r2.ebuild
+++ b/app-misc/splitvt/splitvt-1.6.6-r2.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r2.ebuild,v 1.3 2010/10/23 22:34:45 c1pher Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-misc/splitvt/splitvt-1.6.6-r2.ebuild,v 1.4 2010/10/24 08:24:43 jlec Exp $
 
 EAPI="3"
 
@@ -24,18 +24,18 @@ DEPEND=">=sys-libs/ncurses-5.2"
 RDEPEND="${DEPEND}"
 
 src_prepare() {
-	epatch "${WORKDIR}"/${MY_P}-${DEB_PL}.diff
-	epatch "${FILESDIR}"/${PV}-ldflags.patch
+	epatch \
+		"${WORKDIR}"/${MY_P}-${DEB_PL}.diff \
+		"${FILESDIR}"/${PV}-ldflags.patch
 	sed -i \
 		-e "s:/usr/local/bin:${D}/usr/bin:g" \
 		-e "s:/usr/local/man/:${D}/usr/share/man/:g" config.c || die
 }
 
-src_compile() {
+src_configure() {
 	# upstream has their own weirdo configure script...
 	./configure || die "configure failed"
 	sed -i -e "s:-O2:${CFLAGS}:" -e "s:^CC = gcc:CC = $(tc-getCC):" Makefile || die
-	emake || die "emake failed"
 }
 
 src_install() {