QA: When not using an absolute path, you MUST NOT use a file extension (.png, .svg, or .xpm) on the icon name for make_desktop_entry

Package-Manager: portage--svn/cvs/Linux i686

4 files changed, 20 insertions, 15 deletions

diff --git a/games-fps/quake3-bin/ChangeLog b/games-fps/quake3-bin/ChangeLog
index 6ea78a3fd172..ab39298edd4b 100644
--- a/games-fps/quake3-bin/ChangeLog
+++ b/games-fps/quake3-bin/ChangeLog
@@ -1,6 +1,11 @@
 # ChangeLog for games-fps/quake3-bin
-# Copyright 1999-2009 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/games-fps/quake3-bin/ChangeLog,v 1.29 2009/07/26 10:55:33 nyhm Exp $
+# Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
+# $Header: /var/cvsroot/gentoo-x86/games-fps/quake3-bin/ChangeLog,v 1.30 2010/03/09 12:36:34 abcd Exp $
+
+  09 Mar 2010; Jonathan Callen <abcd@gentoo.org> quake3-bin-1.32c.ebuild,
+  quake3-bin-1.32c-r1.ebuild:
+  QA: When not using an absolute path, you MUST NOT use a file extension
+  (.png, .svg, or .xpm) on the icon name for make_desktop_entry
 
   26 Jul 2009; Tristan Heaven <nyhm@gentoo.org> quake3-bin-1.32c-r1.ebuild:
   Don't install mod symlinks, they should be installed by the mod packages
diff --git a/games-fps/quake3-bin/Manifest b/games-fps/quake3-bin/Manifest
index 6f4960ebdb12..6efd3a97c8ef 100644
--- a/games-fps/quake3-bin/Manifest
+++ b/games-fps/quake3-bin/Manifest
@@ -5,14 +5,14 @@ AUX q3ded.conf.d 307 RMD160 8abab77c1ef7e7fd57c42094e8870ab5f918d21f SHA1 6ca355
 AUX q3ded.rc 853 RMD160 6b8e81f7ef2107f163f319769db4a00c33d445f0 SHA1 dbd451e40b39651dabd983da061aafeeaf7e3a96 SHA256 29c909b4543700733bf481a8bda756bba1d3a2fd6ed08432c801655b47a5b214
 DIST linuxq3apoint-1.32b-3.x86.run 30923961 RMD160 eb63177fc0a30cda4976d8b68e065efb6dc41e50 SHA1 802d84af0d515db50a496c4c55d1f1c4f40a9239 SHA256 c36132c5556b35e01950f1e9c646235033a5130f87ad776ba2bc7becf4f4f186
 DIST quake3-1.32c.zip 3056760 RMD160 d53f3b5a44e1b2871b0a6f1f6e93d9b0ad6d5d10 SHA1 82c52c12682aa4c47628ccfc067e07a56bc65da1 SHA256 643ac677892fb58689a86d71f08d6678393efe2939b82c436a5c92368eebb849
-EBUILD quake3-bin-1.32c-r1.ebuild 3450 RMD160 5e37135b855e54dd0bdfa6ec5b9f1425e82f1509 SHA1 a5a1b9358fdde4eaaec68443b19bd0dc8a953ecc SHA256 a326ec29c74b9505443ce9ccab7ecb2e1534a3142f6cd6b4ff750d12fe84548e
-EBUILD quake3-bin-1.32c.ebuild 3444 RMD160 adf87f284f00a702361efc266a68ceed20e91756 SHA1 3ee58e60fa2b81e71d2408c85a008d686635e4aa SHA256 84d5e1d727d4085cfe2787bd6d110c2a0d95e6d59c384cad532f82171d128d4a
-MISC ChangeLog 9395 RMD160 594722cb06654bea62ce1f93bda4228397db9d4e SHA1 8df676c785e609e89e83ef663bc395d8408e369e SHA256 9d6fe962bd43326f7e311749ac4b11d6d0600026bc5a93c5b6e184ab4f9fa474
+EBUILD quake3-bin-1.32c-r1.ebuild 3447 RMD160 e507681bd57e5771876d531915177db9947932de SHA1 0759f0c8d247b40a3d6b8f9e20d45cca132e0da0 SHA256 980c643e6f75ac60e4b8ac6f7d74b278e145e1b3335c4f8c334aa4cc86bd4a21
+EBUILD quake3-bin-1.32c.ebuild 3437 RMD160 69437e3b88c61c0c5edf85237718dc009730d18a SHA1 7c011fabe1ac1721b1ff877c387de1ce8ce17a13 SHA256 fa550da77b4dd1fa0894b0a81d4ec45bcc7e917d136ee2bd2c107214cb860fe0
+MISC ChangeLog 9637 RMD160 eea35a50989519ec48d2e818c50354682490de1a SHA1 928279b44331d1aeccf78a30ccd4e9f93ccc3d68 SHA256 f2fdc28e336d90b4ab5848749573273103c941cd0bf6cfa9cdb4b902e77ccc22
 MISC metadata.xml 1052 RMD160 47127dc28337531fc3907c9d95f9d7d35d8e2d15 SHA1 08386bbbd1d751866a0201708cabfc8cbdfee975 SHA256 9552624bd6c0d0ac113dc2d283a41c556bd86948c5a14c98fb06e85948feb2aa
 -----BEGIN PGP SIGNATURE-----
-Version: GnuPG v2.0.11 (GNU/Linux)
+Version: GnuPG v2.0.14 (GNU/Linux)
 
-iEYEARECAAYFAkpsNisACgkQdz7hIScOURFkTgCg6bM4+NzqFkXHfv7FnCkSztC5
-f7YAn3TlWdI7wIJqfdrrmgitFfkiccpy
-=kBBE
+iEYEARECAAYFAkuWQNkACgkQOypDUo0oQOqlngCfRau/uU0LVv9nmBEvEo2wmC0y
+n1gAniEJv4PtxDZdmNhcZp18PPMckYm2
+=G5Xm
 -----END PGP SIGNATURE-----
diff --git a/games-fps/quake3-bin/quake3-bin-1.32c-r1.ebuild b/games-fps/quake3-bin/quake3-bin-1.32c-r1.ebuild
index e0d9a813ccce..7150199a76b8 100644
--- a/games-fps/quake3-bin/quake3-bin-1.32c-r1.ebuild
+++ b/games-fps/quake3-bin/quake3-bin-1.32c-r1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2009 Gentoo Foundation
+# Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/games-fps/quake3-bin/quake3-bin-1.32c-r1.ebuild,v 1.9 2009/07/26 10:55:33 nyhm Exp $
+# $Header: /var/cvsroot/gentoo-x86/games-fps/quake3-bin/quake3-bin-1.32c-r1.ebuild,v 1.10 2010/03/09 12:36:34 abcd Exp $
 
 EAPI=2
 inherit eutils games
@@ -86,7 +86,7 @@ src_install() {
 		doexe "Quake III Arena 1.32c"/linux/quake3*.x86 || die "doexe"
 		games_make_wrapper ${PN} ./quake3.x86 "${dir}" "${dir}"
 		newicon quake3.xpm ${PN}.xpm
-		make_desktop_entry ${PN} "Quake III Arena (binary)" ${PN}.xpm
+		make_desktop_entry ${PN} "Quake III Arena (binary)" ${PN}
 		if use teamarena ; then
 			games_make_wrapper ${PN}-teamarena \
 				"./quake3.x86 +set fs_game missionpack" "${dir}" "${dir}"
diff --git a/games-fps/quake3-bin/quake3-bin-1.32c.ebuild b/games-fps/quake3-bin/quake3-bin-1.32c.ebuild
index 16795c626258..48db80a52da4 100644
--- a/games-fps/quake3-bin/quake3-bin-1.32c.ebuild
+++ b/games-fps/quake3-bin/quake3-bin-1.32c.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2008 Gentoo Foundation
+# Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/games-fps/quake3-bin/quake3-bin-1.32c.ebuild,v 1.10 2008/09/26 18:47:42 zmedico Exp $
+# $Header: /var/cvsroot/gentoo-x86/games-fps/quake3-bin/quake3-bin-1.32c.ebuild,v 1.11 2010/03/09 12:36:34 abcd Exp $
 
 inherit eutils games
 
@@ -88,7 +88,7 @@ src_install() {
 			games_make_wrapper ${PN}-teamarena \
 				"./quake3.x86 +set fs_game missionpack" "${dir}" "${dir}"
 			make_desktop_entry ${PN}-teamarena \
-				"Quake III Team Arena (binary)" quake3-bin.xpm
+				"Quake III Team Arena (binary)" quake3-bin
 		fi
 	fi
 	if use dedicated